修复报销附件上传与中文文件名（07-28-travel-reimbursement-guide）

server/tests/unit/routes/invoicePool.file.test.js

@@ -0,0 +1,80 @@
+const fs = require("node:fs/promises");
+const os = require("node:os");
+const path = require("node:path");
+
+const Fastify = require("fastify");
+
+const { AppError } = require("../../../src/utils/AppError");
+const { registerInvoicePoolReadRoutes } = require("../../../src/routes/invoicePool/read");
+const { signPayload } = require("../../../src/utils/signedUrl");
+
+const INVOICE_ID = "11111111-1111-4111-8111-111111111111";
+const ACTOR_ID = "22222222-2222-4222-8222-222222222222";
+const JWT_SECRET = "synthetic-test-secret";
+
+async function buildApp() {
+  const storageDir = await fs.mkdtemp(path.join(os.tmpdir(), "hyb-oa-invoice-file-"));
+  await fs.writeFile(path.join(storageDir, "invoice.pdf"), "%PDF synthetic\n%%EOF\n");
+
+  const prisma = {
+    invoicePool: {
+      findUnique: vi.fn().mockResolvedValue({
+        storage_path: "invoice.pdf",
+        mime_type: "application/pdf",
+        original_name: "住宿电子普通发票.pdf",
+      }),
+    },
+    auditLog: {
+      create: vi.fn().mockResolvedValue({ id: "audit-1" }),
+    },
+  };
+
+  const app = Fastify();
+  app.decorate("prisma", prisma);
+  app.decorate("config", { jwtSecret: JWT_SECRET, storageDir });
+  app.decorate("authenticate", async () => {});
+  app.decorate("hasPermission", () => false);
+  app.decorate("requirePermission", () => async () => {});
+  app.setErrorHandler((error, request, reply) => {
+    if (error instanceof AppError) {
+      return reply.status(error.statusCode).send({
+        requestId: request.id,
+        error: { code: error.code, message: error.message, details: error.details ?? {} },
+      });
+    }
+    return reply.status(500).send({
+      requestId: request.id,
+      error: { code: "SYS_001", message: "服务器内部错误", details: {} },
+    });
+  });
+  await app.register(registerInvoicePoolReadRoutes, { prefix: "/api" });
+  return { app, prisma, storageDir };
+}
+
+describe("GET /api/invoice-pool/:id/file", () => {
+  it("returns a Chinese PDF name through a safe inline Content-Disposition", async () => {
+    const { app, prisma, storageDir } = await buildApp();
+    const exp = Date.now() + 60_000;
+    const token = signPayload({ invoiceId: INVOICE_ID, actorId: ACTOR_ID, exp }, JWT_SECRET);
+
+    try {
+      const response = await app.inject({
+        method: "GET",
+        url: `/api/invoice-pool/${INVOICE_ID}/file?token=${encodeURIComponent(token)}`,
+      });
+
+      expect(response.statusCode).toBe(200);
+      expect(response.headers["content-type"]).toContain("application/pdf");
+      expect(response.headers["content-disposition"]).toBe(
+        "inline; filename=\"attachment.pdf\"; filename*=UTF-8''%E4%BD%8F%E5%AE%BF%E7%94%B5%E5%AD%90%E6%99%AE%E9%80%9A%E5%8F%91%E7%A5%A8.pdf",
+      );
+      expect(response.headers["content-disposition"]).not.toContain("住宿电子普通发票");
+      expect(prisma.auditLog.create).toHaveBeenCalledWith(
+        expect.objectContaining({ data: expect.objectContaining({ action: "INVOICE_FILE_DOWNLOADED" }) }),
+      );
+    } finally {
+      await app.close();
+      await fs.rm(storageDir, { recursive: true, force: true });
+    }
+  });
+});

server/tests/unit/routes/reimbursements.attachments.test.js

@@ -180,7 +180,7 @@ async function buildApp({ reimbursementStatus = "draft" } = {}) {
 
   await app.register(multipart, {
     attachFieldsToBody: false,
-    limits: { files: 5, fileSize: 5 * 1024 * 1024 },
+    limits: { files: 1, fileSize: 5 * 1024 * 1024 },
   });
   await app.register(reimbursementRoutes, { prefix: "/api" });
 
@@ -188,7 +188,7 @@ async function buildApp({ reimbursementStatus = "draft" } = {}) {
 }
 
 describe("reimbursement attachment routes", () => {
-  it("uploads multiple attachment materials without invoice OCR handling", async () => {
+  it("uploads five attachment materials with the production global one-file baseline", async () => {
     const { app, prisma, tempDir, reimbursementId, createdAttachments } = await buildApp();
 
     try {
@@ -204,6 +204,21 @@ describe("reimbursement attachment routes", () => {
             contentType: "image/png",
             content: "png-content",
           },
+          {
+            filename: "order.jpg",
+            contentType: "image/jpeg",
+            content: "jpg-content",
+          },
+          {
+            filename: "note.webp",
+            contentType: "image/webp",
+            content: "webp-content",
+          },
+          {
+            filename: "extra.pdf",
+            contentType: "application/pdf",
+            content: "%PDF extra",
+          },
         ],
       });
 
@@ -218,7 +233,7 @@ describe("reimbursement attachment routes", () => {
       });
 
       expect(response.statusCode).toBe(200);
-      expect(response.json().data.items).toHaveLength(2);
+      expect(response.json().data.items).toHaveLength(5);
       expect(response.json().data.items[0]).toEqual(
         expect.objectContaining({
           originalName: "contract.pdf",
@@ -230,7 +245,7 @@ describe("reimbursement attachment routes", () => {
           uploadedBy: expect.objectContaining({ name: "测试用户" }),
         }),
       );
-      expect(prisma.reimbursementAttachment.create).toHaveBeenCalledTimes(2);
+      expect(prisma.reimbursementAttachment.create).toHaveBeenCalledTimes(5);
       expect(prisma.auditLog.create).toHaveBeenCalledWith(
         expect.objectContaining({
           data: expect.objectContaining({
@@ -254,6 +269,41 @@ describe("reimbursement attachment routes", () => {
     }
   });
 
+  it("returns a stable validation error when a request contains six files", async () => {
+    const { app, prisma, tempDir, reimbursementId } = await buildApp();
+
+    try {
+      const requestPayload = buildMultipartRequest({
+        files: Array.from({ length: 6 }, (_, index) => ({
+          filename: `attachment-${index + 1}.pdf`,
+          contentType: "application/pdf",
+          content: `%PDF attachment ${index + 1}`,
+        })),
+      });
+
+      const response = await app.inject({
+        method: "POST",
+        url: `/api/reimbursements/${reimbursementId}/attachments`,
+        headers: {
+          authorization: "Bearer test",
+          ...requestPayload.headers,
+        },
+        payload: requestPayload.payload,
+      });
+
+      expect(response.statusCode).toBe(400);
+      expect(response.json().error).toMatchObject({
+        code: "VALID_001",
+        details: { file: "too_many_files", maxFiles: 5 },
+      });
+      expect(prisma.reimbursementAttachment.create).not.toHaveBeenCalled();
+      expect(prisma.auditLog.create).not.toHaveBeenCalled();
+    } finally {
+      await app.close();
+      await fs.rm(tempDir, { recursive: true, force: true });
+    }
+  });
+
   it("rejects attachment upload after reimbursement leaves editable status", async () => {
     const { app, prisma, tempDir, reimbursementId } = await buildApp({ reimbursementStatus: "reviewing" });
 
@@ -322,6 +372,9 @@ describe("reimbursement attachment routes", () => {
 
       expect(downloadResponse.statusCode).toBe(200);
       expect(downloadResponse.headers["content-type"]).toContain("image/png");
+      expect(downloadResponse.headers["content-disposition"]).toBe(
+        "inline; filename=\"payment.png\"; filename*=UTF-8''payment.png",
+      );
       expect(downloadResponse.body).toBe("png-content");
 
       const deleteResponse = await app.inject({
@@ -358,6 +411,39 @@ describe("reimbursement attachment routes", () => {
     }
   });
 
+  it("returns Chinese attachment names through a safe inline Content-Disposition", async () => {
+    const { app, tempDir, reimbursementId, createdAttachments } = await buildApp();
+
+    try {
+      const requestPayload = buildMultipartRequest({
+        files: [{ filename: "payment.pdf", contentType: "application/pdf", content: "%PDF payment" }],
+      });
+      const uploadResponse = await app.inject({
+        method: "POST",
+        url: `/api/reimbursements/${reimbursementId}/attachments`,
+        headers: { authorization: "Bearer test", ...requestPayload.headers },
+        payload: requestPayload.payload,
+      });
+      const attachmentId = uploadResponse.json().data.items[0].id;
+      createdAttachments[0].original_name = "支付截图.pdf";
+
+      const response = await app.inject({
+        method: "GET",
+        url: `/api/reimbursements/${reimbursementId}/attachments/${attachmentId}/file`,
+        headers: { authorization: "Bearer test" },
+      });
+
+      expect(response.statusCode).toBe(200);
+      expect(response.headers["content-disposition"]).toBe(
+        "inline; filename=\"attachment.pdf\"; filename*=UTF-8''%E6%94%AF%E4%BB%98%E6%88%AA%E5%9B%BE.pdf",
+      );
+      expect(response.headers["content-disposition"]).not.toContain("支付截图");
+    } finally {
+      await app.close();
+      await fs.rm(tempDir, { recursive: true, force: true });
+    }
+  });
+
   it("rejects attachment deletion without a meaningful reason before mutation", async () => {
     const { app, prisma, tempDir, reimbursementId } = await buildApp();
 

server/tests/unit/services/purchaseAttachmentPolicy.test.js

@@ -542,4 +542,13 @@ describe("purchase attachment storage and response helpers", () => {
     expect(header).not.toContain("\\quote");
     expect(header).toContain("filename*=UTF-8''");
   });
+
+  it("supports safe inline Content-Disposition without changing the default", () => {
+    const header = buildAttachmentContentDisposition("铁路电子客票.pdf", { disposition: "inline" });
+
+    expect(header).toBe(
+      "inline; filename=\"attachment.pdf\"; filename*=UTF-8''%E9%93%81%E8%B7%AF%E7%94%B5%E5%AD%90%E5%AE%A2%E7%A5%A8.pdf",
+    );
+    expect(() => buildAttachmentContentDisposition("file.pdf", { disposition: "preview" })).toThrow(TypeError);
+  });
 });