完善借款、编号、付款与预算并发及验收(09-06-release-gate-integrity)
汇总已落盘的借款本金与还款、兼容历史编号的周期化编号、付款责任与回单核验、报销进度和排序、PWA/采购事务、错误原因与日期校验及ERP退役。 统一共享预算池锁序和锁后判断,恢复差旅原预算选择,补原因码固定夹具及反向完整性检查。 纳入配套迁移、测试、受管QA、分层验收合同、规约及任务记录;原始证据留在ignored artifacts。 关联任务:09-17-company-loan-principal-repayment、09-17-erp-exclusive-retirement、09-18-reimbursement-periodic-numbering、09-08-reimbursement-payment-closeout、09-18-local-concurrency-product-fixes、09-19-budget-pool-concurrency、09-05-error-explainability-payment-readiness。 预算补审由Claude定向验证2文件928项通过,原4446/28及r6结果仍仅对应各自历史输入;本轮未重跑测试。 完整新候选门禁、R1真实入口接入与12项公网义务仍开放。生产编号未启用、差旅仍冻结;不推送、不部署,不宣称发布资格。
这个提交包含在:
@@ -1,6 +1,8 @@
|
||||
const {
|
||||
summarizeBudgetLedgerByPool,
|
||||
buildPurchaseBudgetValidationError,
|
||||
reserveBudgetForEntity,
|
||||
confirmBudgetForEntity,
|
||||
releaseReservedBudgetIfAny,
|
||||
} = require("../../../src/services/purchaseBudget");
|
||||
|
||||
describe("purchaseBudget service", () => {
|
||||
@@ -32,10 +34,62 @@ describe("purchaseBudget service", () => {
|
||||
]);
|
||||
});
|
||||
|
||||
it("builds VALID_001 validation error", () => {
|
||||
const error = buildPurchaseBudgetValidationError({ budget: "reserve_already_exists" });
|
||||
expect(error.code).toBe("VALID_001");
|
||||
expect(error.statusCode).toBe(409);
|
||||
expect(error.details).toEqual({ budget: "reserve_already_exists" });
|
||||
function fixture(entries = [], pool = { id: "pool-1", used_amount: "20.00" }) {
|
||||
return {
|
||||
$queryRaw: vi.fn().mockResolvedValue([]),
|
||||
budgetLedgerEntry: { findMany: vi.fn().mockResolvedValue(entries), create: vi.fn().mockResolvedValue({}) },
|
||||
budgetPool: { findUnique: vi.fn().mockResolvedValue(pool), update: vi.fn().mockResolvedValue({}) },
|
||||
};
|
||||
}
|
||||
const input = { budgetPoolId: "pool-1", entityType: "purchase_request", entityId: "synthetic-request", amount: "12.34", actorId: "synthetic-actor", note: "synthetic" };
|
||||
|
||||
it("explains duplicate reserve before writes", async () => {
|
||||
const tx = fixture([{ budget_pool_id: "pool-1", kind: "reserve", amount: "10.00" }]);
|
||||
await expect(reserveBudgetForEntity(tx, input)).rejects.toMatchObject({ code: "VALID_001", statusCode: 409, details: { budget: "reserve_already_exists", reasonCode: "purchase_budget.reserve_already_exists" } });
|
||||
expect(tx.budgetLedgerEntry.create).not.toHaveBeenCalled();
|
||||
expect(tx.budgetPool.findUnique).not.toHaveBeenCalled();
|
||||
expect(tx.budgetPool.update).not.toHaveBeenCalled();
|
||||
});
|
||||
it("preserves attempted ledger before missing-pool rejection", async () => {
|
||||
const tx = fixture([], null);
|
||||
await expect(reserveBudgetForEntity(tx, input)).rejects.toMatchObject({ code: "VALID_001", statusCode: 409, details: { budgetPoolId: "not_found", reasonCode: "purchase_budget.pool_not_found" } });
|
||||
expect(tx.budgetLedgerEntry.create).toHaveBeenCalledWith({ data: { budget_pool_id: "pool-1", entity_type: "purchase_request", entity_id: "synthetic-request", kind: "reserve", amount: "12.34", created_by: "synthetic-actor", note: "synthetic" } });
|
||||
expect(tx.budgetLedgerEntry.create.mock.invocationCallOrder[0]).toBeLessThan(tx.budgetPool.findUnique.mock.invocationCallOrder[0]);
|
||||
expect(tx.budgetPool.update).not.toHaveBeenCalled();
|
||||
});
|
||||
it("retains successful reserve precision and pool accumulation", async () => {
|
||||
const tx = fixture();
|
||||
await expect(reserveBudgetForEntity(tx, input)).resolves.toEqual({ applied: true, reservedAmount: "12.34" });
|
||||
expect(tx.budgetPool.update).toHaveBeenCalledWith({ where: { id: "pool-1" }, data: { used_amount: "32.34", updated_by: "synthetic-actor" } });
|
||||
});
|
||||
it.each([{ budgetPoolId: null }, { amount: "0" }, { amount: "-1" }, { amount: "invalid" }])("retains no-op reserve %s", async (override) => {
|
||||
const tx = fixture();
|
||||
await expect(reserveBudgetForEntity(tx, { ...input, ...override })).resolves.toEqual({ applied: false, reservedAmount: "0.00" });
|
||||
expect(tx.$queryRaw).not.toHaveBeenCalled();
|
||||
for (const model of [tx.budgetLedgerEntry, tx.budgetPool]) for (const fn of Object.values(model)) expect(fn).not.toHaveBeenCalled();
|
||||
});
|
||||
it("confirms remaining amount once without touching pool", async () => {
|
||||
const tx = fixture([{ budget_pool_id: "pool-1", kind: "reserve", amount: "12.34" }, { budget_pool_id: "pool-1", kind: "confirm", amount: "2.34" }]);
|
||||
await expect(confirmBudgetForEntity(tx, input)).resolves.toEqual({ applied: true, items: [{ budgetPoolId: "pool-1", amount: "10.00" }] });
|
||||
expect(tx.budgetLedgerEntry.create).toHaveBeenCalledWith({ data: expect.objectContaining({ kind: "confirm", amount: "10.00" }) });
|
||||
expect(tx.budgetPool.findUnique).not.toHaveBeenCalled();
|
||||
expect(tx.budgetPool.update).not.toHaveBeenCalled();
|
||||
});
|
||||
it("retains missing-pool release success with ledger and no pool update", async () => {
|
||||
const tx = fixture([{ budget_pool_id: "pool-1", kind: "reserve", amount: "12.34" }], null);
|
||||
await expect(releaseReservedBudgetIfAny(tx, input)).resolves.toEqual({ applied: true, items: [{ budgetPoolId: "pool-1", amount: "12.34" }] });
|
||||
expect(tx.budgetLedgerEntry.create).toHaveBeenCalledWith({ data: expect.objectContaining({ kind: "release", amount: "12.34" }) });
|
||||
expect(tx.budgetPool.update).not.toHaveBeenCalled();
|
||||
});
|
||||
it("retains release clamping and no-op fully released ledger", async () => {
|
||||
const tx = fixture([{ budget_pool_id: "pool-1", kind: "reserve", amount: "30.00" }]);
|
||||
await releaseReservedBudgetIfAny(tx, input);
|
||||
expect(tx.budgetPool.update).toHaveBeenCalledWith({ where: { id: "pool-1" }, data: { used_amount: "0.00", updated_by: "synthetic-actor" } });
|
||||
const completed = fixture([{ budget_pool_id: "pool-1", kind: "reserve", amount: "30.00" }, { budget_pool_id: "pool-1", kind: "release", amount: "30.00" }]);
|
||||
await expect(releaseReservedBudgetIfAny(completed, input)).resolves.toEqual({ applied: false, items: [] });
|
||||
await expect(confirmBudgetForEntity(completed, input)).resolves.toEqual({ applied: false, items: [] });
|
||||
expect(completed.budgetLedgerEntry.create).not.toHaveBeenCalled();
|
||||
expect(completed.budgetPool.findUnique).not.toHaveBeenCalled();
|
||||
expect(completed.budgetPool.update).not.toHaveBeenCalled();
|
||||
});
|
||||
});
|
||||
|
||||
在新工单中引用
屏蔽一个用户