完善借款、编号、付款与预算并发及验收（09-06-release-gate-integrity）
汇总已落盘的借款本金与还款、兼容历史编号的周期化编号、付款责任与回单核验、报销进度和排序、PWA/采购事务、错误原因与日期校验及ERP退役。 统一共享预算池锁序和锁后判断，恢复差旅原预算选择，补原因码固定夹具及反向完整性检查。 纳入配套迁移、测试、受管QA、分层验收合同、规约及任务记录；原始证据留在ignored artifacts。 关联任务：09-17-company-loan-principal-repayment、09-17-erp-exclusive-retirement、09-18-reimbursement-periodic-numbering、09-08-reimbursement-payment-closeout、09-18-local-concurrency-product-fixes、09-19-budget-pool-concurrency、09-05-error-explainability-payment-readiness。 预算补审由Claude定向验证2文件928项通过，原4446/28及r6结果仍仅对应各自历史输入；本轮未重跑测试。 完整新候选门禁、R1真实入口接入与12项公网义务仍开放。生产编号未启用、差旅仍冻结；不推送、不部署，不宣称发布资格。
这个提交包含在：
@@ -1,3 +1,4 @@
|
||||
const { enableNumbering } = require("../helpers/activeNumbering");
|
||||
const Fastify = require("fastify");
|
||||
|
||||
const { AppError } = require("../../../src/utils/AppError");
|
||||
@@ -127,6 +128,8 @@ function createPrismaState({ communicationLogs = [], closureChecklistItems = [],
|
||||
}
|
||||
|
||||
const prisma = {
|
||||
businessNumberPolicy: { findUnique: vi.fn(async () => null) },
|
||||
$executeRaw: vi.fn(async () => 0),
|
||||
featureFlag: {
|
||||
findUnique: vi.fn().mockImplementation(async ({ where }) => buildFeatureFlagRecord(where.flag_key)),
|
||||
},
|
||||
@@ -297,6 +300,7 @@ function createPrismaState({ communicationLogs = [], closureChecklistItems = [],
|
||||
},
|
||||
};
|
||||
|
||||
prisma.$transaction = vi.fn(async (cb) => cb(prisma));
|
||||
return { state, prisma };
|
||||
}
|
||||
|
||||
@@ -563,3 +567,106 @@ describe("project R23 routes", () => {
|
||||
await app.close();
|
||||
});
|
||||
});
|
||||
|
||||
const ERROR_CHILD_ID = "66666666-6666-4666-8666-666666666666";
|
||||
const errorApps = [];
|
||||
afterEach(async () => { await Promise.all(errorApps.splice(0).map((app) => app.close())); });
|
||||
async function errorContext({ employee = { id: OWNER_ID, permissionCodes: ["project.manage"] }, emptyChecklist = false } = {}) {
|
||||
const context = createPrismaState({
|
||||
communicationLogs: [{ id: ERROR_CHILD_ID, project_id: PROJECT_ID, summary: "合成沟通", channel: "meeting", happened_at: NOW, created_at: NOW, created_by: OWNER_ID }],
|
||||
closureChecklistItems: emptyChecklist ? [] : [{ id: ERROR_CHILD_ID, project_id: PROJECT_ID, status: "pending", title: "合成收口项", sort_order: 1, note: null }],
|
||||
});
|
||||
const { prisma, state } = context;
|
||||
for (const model of ["projectMember", "projectMilestone", "projectTask", "projectRisk", "projectDeliveryRecord"]) {
|
||||
prisma[model] ??= {};
|
||||
for (const method of ["create", "update", "upsert"]) prisma[model][method] = vi.fn(async ({ data, create }) => ({ id: ERROR_CHILD_ID, project_id: PROJECT_ID, ...(data ?? create) }));
|
||||
}
|
||||
prisma.project.create = vi.fn(async ({ data }) => ({ ...state.project, project_no: data.project_no }));
|
||||
prisma.project.findMany = vi.fn().mockResolvedValue([]);
|
||||
const app = await buildApp({ employee, prisma }); errorApps.push(app);
|
||||
return { ...context, app };
|
||||
}
|
||||
function errorRequest(method, suffix, payload) { return { method, url: `/api/projects${suffix}`, headers: { authorization: "Bearer synthetic-test" }, ...(payload ? { payload } : {}) }; }
|
||||
function noProjectMutations(prisma, { bootstrap = false } = {}) {
|
||||
for (const model of ["project", "projectMember", "projectMilestone", "projectTask", "projectRisk", "projectDeliveryRecord", "projectCommunicationLog", "projectClosureChecklistItem"]) {
|
||||
for (const method of ["create", "update", "upsert"]) if (prisma[model]?.[method]) expect(prisma[model][method]).not.toHaveBeenCalled();
|
||||
}
|
||||
expect(prisma.auditLog.create).not.toHaveBeenCalled();
|
||||
if (!bootstrap) expect(prisma.projectClosureChecklistItem.createMany).not.toHaveBeenCalled();
|
||||
}
|
||||
function expectProjectError(response, status, reasonCode, details) { expect(response.statusCode).toBe(status); expect(response.json().error).toMatchObject({ code: "VALID_001", details: { ...details, reasonCode } }); }
|
||||
const projectInputOperations = [
|
||||
["POST", "", "create_input_invalid"], ["PATCH", `/${PROJECT_ID}`, "update_input_invalid"],
|
||||
...[["members", "member"], ["milestones", "milestone"], ["tasks", "task"], ["risks", "risk"], ["communication-logs", "communication_log"]].flatMap(([path, reason]) => [["POST", `/${PROJECT_ID}/${path}`, `${reason}_create_input_invalid`], ["PATCH", `/${PROJECT_ID}/${path}/${ERROR_CHILD_ID}`, `${reason}_update_input_invalid`]]),
|
||||
["PATCH", `/${PROJECT_ID}/closure-checklist/${ERROR_CHILD_ID}`, "closure_checklist_update_input_invalid"],
|
||||
["POST", `/${PROJECT_ID}/deliveries`, "delivery_create_input_invalid"],
|
||||
];
|
||||
it.each(projectInputOperations)("explains %s %s invalid input without target mutations", async (method, suffix, reason) => {
|
||||
const { app, prisma } = await errorContext(); const response = await app.inject(errorRequest(method, suffix, {}));
|
||||
expectProjectError(response, 400, `project.${reason}`, { formErrors: expect.any(Array), fieldErrors: expect.any(Object) }); noProjectMutations(prisma);
|
||||
});
|
||||
it.each([
|
||||
["/bad", "id", "id_invalid"],
|
||||
...[["members", "memberId", "member"], ["milestones", "milestoneId", "milestone"], ["tasks", "taskId", "task"], ["risks", "riskId", "risk"], ["communication-logs", "logId", "communication_log"], ["closure-checklist", "itemId", "closure_checklist"]].map(([path, key, reason]) => [`/${PROJECT_ID}/${path}/bad`, key, `${reason}_id_invalid`]),
|
||||
])("explains invalid project reference %s", async (suffix, key, reason) => {
|
||||
const { app, prisma } = await errorContext(); expectProjectError(await app.inject(errorRequest("PATCH", suffix, {})), 400, `project.${reason}`, { [key]: "invalid_uuid" }); noProjectMutations(prisma);
|
||||
});
|
||||
it.each([
|
||||
["", "project_domain_v1", "feature_disabled", "projectDomainEnabled"],
|
||||
[`/${PROJECT_ID}/weekly-reports`, "project_linking_v1", "linking_disabled", "projectLinkingEnabled"],
|
||||
[`/${PROJECT_ID}/communication-logs`, "project_communication_log_v1", "communication_disabled", "projectCommunicationLogEnabled"],
|
||||
[`/${PROJECT_ID}/closure-checklist`, "project_closure_checklist_v1", "closure_disabled", "projectClosureChecklistEnabled"],
|
||||
[`/${PROJECT_ID}/document-refs`, "confidential_doc_refs_v1", "document_refs_disabled", "confidentialDocRefsEnabled"],
|
||||
].flatMap((row) => [false, true].map((envOff) => [...row, envOff])))("preserves %s feature gate %s before business access", async (suffix, flag, reason, configKey, envOff) => {
|
||||
const { app, prisma } = await errorContext();
|
||||
if (envOff) app.config[configKey] = false;
|
||||
else prisma.featureFlag.findUnique.mockImplementation(async ({ where }) => ({ ...buildFeatureFlagRecord(where.flag_key), override_mode: "force_off" }));
|
||||
expectProjectError(await app.inject(errorRequest("GET", suffix)), 409, `project.${reason}`, { featureFlag: `${flag}_disabled`, reason: envOff ? "env_hard_off" : "flag_force_off" });
|
||||
expect(prisma.project.findUnique).not.toHaveBeenCalled(); expect(prisma.project.findMany).not.toHaveBeenCalled(); noProjectMutations(prisma);
|
||||
if (envOff) expect(prisma.featureFlag.findUnique).not.toHaveBeenCalled();
|
||||
});
|
||||
it("explains invalid project query after the feature gate", async () => {
|
||||
const { app, prisma } = await errorContext(); expectProjectError(await app.inject(errorRequest("GET", "?mine=invalid")), 400, "project.query_invalid", { fieldErrors: { mine: expect.any(Array) } }); expect(prisma.project.findMany).not.toHaveBeenCalled(); noProjectMutations(prisma);
|
||||
});
|
||||
it.each(["status", "clear-note"])("keeps waived note guard on %s", async (mode) => {
|
||||
const { app, prisma, state } = await errorContext(); if (mode === "clear-note") { state.closureChecklistItems[0].status = "waived"; state.closureChecklistItems[0].note = "合成理由"; }
|
||||
expectProjectError(await app.inject(errorRequest("PATCH", `/${PROJECT_ID}/closure-checklist/${ERROR_CHILD_ID}`, mode === "status" ? { status: "waived", note: " " } : { note: null })), 400, "project.waiver_note_required", { note: "waived_requires_note" }); noProjectMutations(prisma);
|
||||
});
|
||||
it.each(["invalid-id", "invalid-body"])("documents existing checklist bootstrap before %s validation", async (mode) => {
|
||||
const { app, prisma, state } = await errorContext({ emptyChecklist: true });
|
||||
const firstId = "99999999-9999-4999-8999-000000000100";
|
||||
const response = await app.inject(errorRequest("PATCH", `/${PROJECT_ID}/closure-checklist/${mode === "invalid-id" ? "bad" : firstId}`, {}));
|
||||
expectProjectError(response, 400, `project.closure_checklist_${mode === "invalid-id" ? "id_invalid" : "update_input_invalid"}`, {});
|
||||
expect(prisma.projectClosureChecklistItem.createMany).toHaveBeenCalledTimes(1); expect(state.closureChecklistItems).toHaveLength(6); noProjectMutations(prisma, { bootstrap: true });
|
||||
});
|
||||
it.each(projectInputOperations.filter(([,suffix]) => !suffix.includes("closure-checklist")))("keeps permission before %s %s validation", async (method, suffix) => {
|
||||
const { app, prisma } = await errorContext({ employee: { id: OUTSIDER_ID, permissionCodes: [] } }); const response = await app.inject(errorRequest(method, suffix, {})); expect(response.statusCode).toBe(403); expect(response.json().error.code).toBe("PERM_001"); noProjectMutations(prisma);
|
||||
});
|
||||
it.each([
|
||||
["members", "projectMember", { employeeId: MEMBER_ID }, { role: "observer" }],
|
||||
["milestones", "projectMilestone", { title: "合成里程碑" }, { title: "合成修改" }],
|
||||
["tasks", "projectTask", { title: "合成任务" }, { priority: "high" }],
|
||||
["risks", "projectRisk", { title: "合成风险", detail: "合成说明" }, { level: "high" }],
|
||||
].flatMap((row) => ["POST", "PATCH"].map((method) => [...row, method])))("preserves valid %s %s operation", async (path, model, createPayload, patchPayload, method) => {
|
||||
const { app, prisma } = await errorContext(); const response = await app.inject(errorRequest(method, `/${PROJECT_ID}/${path}${method === "PATCH" ? `/${ERROR_CHILD_ID}` : ""}`, method === "POST" ? createPayload : patchPayload)); expect(response.statusCode).toBe(method === "POST" ? 201 : 200);
|
||||
expect(prisma[model][method === "PATCH" ? "update" : model === "projectMember" ? "upsert" : "create"]).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
it("preserves valid project create and delivery create", async () => {
|
||||
const { app, prisma } = await errorContext(); const created = await app.inject(errorRequest("POST", "", { projectNo: "SYNTHETIC", name: "合成项目", clientName: "合成客户" })); expect(created.statusCode).toBe(201); expect(prisma.project.create).toHaveBeenCalledTimes(1);
|
||||
const delivery = await app.inject(errorRequest("POST", `/${PROJECT_ID}/deliveries`, { title: "合成交付", recordType: "handover", summary: "合成说明", occurredAt: "2026-01-01T00:00:00Z" })); expect(delivery.statusCode).toBe(201); expect(prisma.projectDeliveryRecord.create).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
it("preserves valid waived note and completion metadata", async () => {
|
||||
const { app, prisma } = await errorContext(); const response = await app.inject(errorRequest("PATCH", `/${PROJECT_ID}/closure-checklist/${ERROR_CHILD_ID}`, { status: "waived", note: "合成理由" })); expect(response.statusCode).toBe(200);
|
||||
expect(prisma.projectClosureChecklistItem.update).toHaveBeenCalledWith(expect.objectContaining({ data: { status: "waived", note: "合成理由", completed_at: expect.any(Date), completed_by: OWNER_ID } })); expect(prisma.auditLog.create).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
|
||||
it("allocates project numbers inside creation and reserves formal matching codes", async () => {
|
||||
const { app, prisma } = await errorContext(); enableNumbering(prisma);
|
||||
const response = await app.inject(errorRequest("POST", "", { name: "合成年度项目", clientName: "合成客户" }));
|
||||
expect(response.statusCode).toBe(201);
|
||||
expect(prisma.project.create.mock.calls[0][0].data.project_no).toMatch(/^PRJ-\d{4}-0001$/);
|
||||
const formal = await app.inject(errorRequest("POST", "", { projectNo: "PRJ-2026-0050", name: "合成手工号", clientName: "合成客户" }));
|
||||
expect(formal.statusCode).toBe(201);
|
||||
expect(prisma.project.create.mock.calls[1][0].data.project_no).toBe("PRJ-2026-0050");
|
||||
expect(prisma.businessNumberCounter.upsert.mock.calls.at(-1)[0].update.current_number).toBe(50n);
|
||||
});
|
||||
|
||||
在新工单中引用
屏蔽一个用户